[sbopkg-users] pkg options inconsistency and potential fix

[Christoph Willing]

In the queuefiles page at the sbopkg website, it is stated:

     In cases where the user has passed options on the command line
     and/or saved build options individually via the dialog interface,
     and also puts build options for that same application in the
     queuefile, sbopkg will ask the user which set should be used.

It is not stated - but it could be assumed - that if any options are 
passed by only _one_ of the methods, there is no point in asking which 
method to use.

If I have passed options only via a queuefile, then I don't want to be 
asked which of only 1 choice I wish to use - it doesn't make sense. 
However that is what currently occurs i.e. if I submit a queuefile with 
options only in the queuefile, I am asked if I want to use them - even 
if -B option to sbopkg is used. I suppose it gives an opportunity to 
reject the options in the queuefile but if I have explicitly added 
options to a queuefile, I don't want to be asked if I really meant it. 
You may as well ask if I really meant to build package abc, xyz, etc. 
that might be in the queuefile. In fact, I put the package names and the 
options into the queuefile so they would be processed.

For a single package or queuefile with very few packages, this is not a 
big deal. However for queuefiles with many packages which may have 
options, this is not so good - after many times its annoying. In my 
particular use case, I want to process arbitrary queues inside a VM in a 
scripted manner i.e. I don't want to have to log into it to answer 
questions - I just want it to do what I script it to do.

I have attached a patch, against the latest release, which fixes the 
issue for me. If options are passed by only one of the approved methods 
then processing continues without question, however if options exist 
from more that one method the previous code (asking which option to use) 
is run as before.

I hope you can use the patch - or something else you may decide - to fix 
this inconsistency in the next release.


chris
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sbopkg_options.diff
Type: text/x-patch
Size: 4148 bytes
Desc: not available
URL: <http://sbopkg.org/pipermail/sbopkg-users/attachments/20140921/8edeaa72/attachment.bin>