[sbopkg-discuss] Re: Feature request - show diffs

[Phillip Warner]

On 2/17/09, Chess Griffin <chess at chessgriffin.com> wrote:
> I prefer keeping the temp file for the reason Mauro mentioned in
> addition to being able to view it more than once.
You can still view it more than once, but it diffs everytime.  These
files are small so it's not like there is a performance hit, and how
many times are people going to hit 'Diff' over and over again.  Do you
mean open another *term and view the tmp file itself?

What dialog does not show up?  When I test it I choose the diff option
and the diff dialog with the title and OK button shows up.  Of course
there is nothing in the dialog, but that is simply because there are
no differences to show.  This could be made less confusing
(particularly for the non-dialog version) by making the default
DIFFOPS=-su.

Did y'all mean that you don't want the Local/Original/Diff Dialog to
show up if the files are the same?  If that is the case, then instead
of using a tmp file why not have a statement similar to this

if [ -n "$(diff -q file1 file2 2>/dev/null)" ]; then
  # do_dialog_code
fi

This would keep y'all from having to manage even more tmp files.

> Honestly, I am not
> sure if $DIFF and $DIFFOPTS are really needed -- the idea here is just
> to provide a simple means of showing a diff.  We're only showing
> differences between .info and the SlackBuild scripts, so isn't diff -u
> sufficient?
Some people don't care about spacing.  Some like unified diffs, and
others like standard.  Maybe someone wants to use colordiff instead of
diff itself (for non dialog).  I just thought it would be nice to have
these options.  You could define the vars at the top so the code is
simpler.

--phillip

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "sbopkg-discuss" group.
To post to this group, send email to sbopkg-discuss at googlegroups.com
To unsubscribe from this group, send email to sbopkg-discuss+unsubscribe at googlegroups.com
For more options, visit this group at http://groups.google.com/group/sbopkg-discuss?hl=en
-~----------~----~----~----~------~----~------~--~---