[sbopkg-discuss] Re: Feature request - show diffs

[Chess Griffin]

* Mauro Giachero <mauro.giachero at gmail.com> [2009-02-18 10:03:08]:

> On Wed, Feb 18, 2009 at 6:29 AM, Phillip Warner
> <phillip.c.warner at gmail.com>wrote:
> 
> > [...]
> > Did y'all mean that you don't want the Local/Original/Diff Dialog to
> > show up if the files are the same?
> 
> 
> Exactly. Sorry if I used a bad wording.

Yes, that was the current behavior which is preferable.

> 
> 
> > If that is the case, then instead
> > of using a tmp file why not have a statement similar to this
> >
> > if [ -n "$(diff -q file1 file2 2>/dev/null)" ]; then
> >  # do_dialog_code
> > fi
> >
> > This would keep y'all from having to manage even more tmp files.
> 
> 
> But this would to the diff twice...
> I really think it's a matter of taste here. Frankly, I'm not worried about
> temp files whose lifespan doesn't exceed that of a single function -- after
> all, it's rather easy to manage them correctly.
> 

I agree.  Let's go with Mauro's patch that leaves the tmp file and includes
the DIFF and DIFFOPTS variables.

-- 
Chess Griffin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://sbopkg.org/pipermail/sbopkg-users/attachments/20090218/850ece99/attachment.sig>